Make the CI more robust w.r.t. the test_comp_bisim job
#2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not doing so gives Mergify the freedom to merge a PR even if the `coverage` CI test job fails, as observed in #2023.
Locally, this shaves off about 10 seconds from the overall verification time, and it should make this test case finish more reliably within the CI's time limits. Co-authored-by: Eddy Westbrook <[email protected]>
Sadly, building SAW with coverage enabled causes it to use noticeably more memory at runtime, which is enough to exceed the GitHub Actions CI runners' maximum memory and cause the job to be SIGKILL'ed when running the `test_comp_bisim` job. It's not obvious how to fix this, so we simply disable the `test_comp_bisim` job in CI when running with coverage enabled.
This ensures that the default GHC version that GitHub Actions provides (which is not fixed and is likely not to match the version that was used to build SAW with coverage) does not influence which version of `hpc` is fixed to compute code coverage.
RyanGlScott
force-pushed
the
ci-robustness-tweaks
branch
from
1324ec2
to
d9aff06
Compare
RyanGlScott
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of various CI and test case–related fixes, observed in the aftermath of #2023:
Mergify: Require
coveragetest job to passNot doing so gives Mergify the freedom to merge a PR even if the
coverageCI test job fails, as observed in #2023.Make
test_comp_bisimcomplete in slightly less timeLocally, this shaves off about 10 seconds from the overall verification time, and it should make this test case finish more reliably within the CI's time limits.
Skip test_comp_bisim test with coverage enabled
Sadly, building SAW with coverage enabled causes it to use noticeably more memory at runtime, which is enough to exceed the GitHub Actions CI runners' maximum memory and cause the job to be SIGKILL'ed when running the
test_comp_bisimjob. It's not obvious how to fix this, so we simply disable thetest_comp_bisimjob in CI when running with coverage enabled.CI: Install specific HPC version on coverage job
This ensures that the default GHC version that GitHub Actions provides (which is not fixed and is likely not to match the version that was used to build SAW with coverage) does not influence which version of
hpcis fixed to compute code coverage.